-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic watching ability to v2 cli #734
Add basic watching ability to v2 cli #734
Conversation
Codecov Report
@@ Coverage Diff @@
## master #734 +/- ##
==========================================
- Coverage 46.75% 46.70% -0.05%
==========================================
Files 125 126 +1
Lines 54903 54970 +67
==========================================
+ Hits 25672 25676 +4
- Misses 29231 29294 +63
Continue to review full report at Codecov.
|
Thanks for submitting this! I am a little wary about using I'm a bit tied up for the rest of this week but I'll try to review this in more depth soon. |
48d1ea5
to
fd10d86
Compare
I've updated this to use the current executable name (prettified) for the command now so it also works when not running I think I'd expect that the list of files to watch from the Makefile rules would be able to be used as included paths to |
Hi, I just wanted to apologize for the slow follow-up here — I've had a lot going on preventing me from spending time on Tectonic lately. But I haven't forgotten about this! |
I'd be interested in a fancier implementation that avoids re-execing the Tectonic executable, but let's merge this now and get the functionality it. The implementation can always be reworked later if/when needed. |
Fixes #719
This adds the
watch
subcommand, based off ofcargo-watch
. This design should allow for future addition of subcommands such ascheck
orformat
which may run after or before a build stage or in place of one. It is very dumb at the moment and just watches all files in the current directory, besides the outputbuild
dir.Tested that it works for me on a setup from
tectonic -X new
.Haven't really got a good idea of how to go about testing this kind of thing but most of the work is done by the
watchexec
crate anyway.